D14904: TOC: Add collapse/expand options

[Peter Wu]

Lekensteyn added a comment.


  In D14904#313718 <https://phabricator.kde.org/D14904#313718>, @aacid wrote:
  
  > The braces are all in the wrong place
  
  
  Which braces?

INLINE COMMENTS

> aacid wrote in part.cpp:2996
> Would "Collapse children" instead of just "Collapse" make more sense? For some reason my brain thought this would close up until the root when i read "Collapse recursively"

"Collapse all" would close every section, "Collapse recursively" intended to work downwards instead of to the top (what would the use case be for the latter?)

Also, considering the non-programmers, "Collapse children" might be a confusing message.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14904

To: Lekensteyn, #okular, ngraham
Cc: sander, aacid, ngraham, okular-devel, #okular
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180823/f1713c29/attachment.html>