[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

Albert Astals Cid bugzilla_noreply at kde.org
Mon Aug 13 10:14:29 BST 2018


https://bugs.kde.org/show_bug.cgi?id=389668

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/oku
                   |                            |lar/5e622484c874a81718faaac
                   |                            |3d948d355d4e03164
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Albert Astals Cid <aacid at kde.org> ---
Git commit 5e622484c874a81718faaac3d948d355d4e03164 by Albert Astals Cid, on
behalf of Ahmad Osama.
Committed on 13/08/2018 at 09:13.
Pushed by aacid into branch 'Applications/18.08'.

Fix problem of saving pdf switches from thumbnail view in sidebar to contents
view

Summary:
When save/save as functions are called they internally call the openFile()
function, in the open file function the side bar item is set to Table of
Contents (ToC) item

```
if ( m_document->metaData( QStringLiteral("OpenTOC") ).toBool() &&
m_sidebar->isItemEnabled( m_toc ) && !m_sidebar->isCollapsed() &&
m_sidebar->currentItem() != m_toc )
{
     m_sidebar->setCurrentItem( m_toc, Sidebar::DoNotUncollapseIfCollapsed );
}
```
so I just store the sidebar's item before saving and then set this item back if
changed.

Reviewers: #okular

Subscribers: aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D14740

M  +19   -0    autotests/parttest.cpp
M  +4    -0    part.cpp
M  +2    -1    ui/sidebar.h

https://commits.kde.org/okular/5e622484c874a81718faaac3d948d355d4e03164

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list