D11596: Add support for dynamic visibility

Albert Astals Cid noreply at phabricator.kde.org
Mon Apr 16 21:41:20 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> generator_pdf.cpp:459
> +            }
> +            link = new Okular::ScriptAction( Okular::JavaScript, scripts.join( QLatin1Char( '\n' ) ) );
> +        }

I understand why you're going through javascript for this, it kind of makes it a bit easier for you since you don't have to define a new linkaction type in okular, but i am not convinced it's the best solution, let me sleep on it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11596

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180416/153a8a7d/attachment-0001.html>


More information about the Okular-devel mailing list