D12001: use correct filepath

Fabian Kosmale noreply at phabricator.kde.org
Fri Apr 6 22:47:11 UTC 2018


fabiank created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
fabiank requested review of this revision.

REVISION SUMMARY
  Seems like someone forgot to consistently apply a change. Maybe the path
  construction should be factored into a reusable lambda?

TEST PLAN
  Open Okular, open settings > configure Okular. Without the patch, you'll get a
  "QFSFileEngine::open: No file name specified" warning, with the patch it
  disappears. Note that there is also an unrelated "Illegal icon group:  7"
  warning from KIconThemes, but I'm 99% certain that this is on KIconThemes doing
  a bogus check in KIconEffect::apply, not on Okular

REPOSITORY
  R223 Okular

BRANCH
  fixWarnings

REVISION DETAIL
  https://phabricator.kde.org/D12001

AFFECTED FILES
  ui/pageviewannotator.cpp

To: fabiank
Cc: #okular, michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180406/e8884d58/attachment.html>


More information about the Okular-devel mailing list