Review Request 130219: Enable background color to be changed from settings
rkflx at lab12.net
Thu Sep 28 23:13:44 UTC 2017
(Sorry for the noise, seems like Reviewboard does not let me comment anymore?)
Thanks for providing a patch instead of just complaining on Bugzilla. As Reviewboard will become readonly in the near future, I would encourage you to bring this review over to Phabricator, so we can discuss further improvements (if you are still interested, which I hope, as the latest version of your patch is much improved).
For example, you could improve the wording and layout:
[ ] Use custom background color: [color chooser] (← Note inversion of checkbox logic, and disable colour chooser if checkbox is unchecked. Possibly decrease the colour chooser's width.)
Advantages: Does away with the unmeaningful "Use UI theme", does not duplicate the words "background color" and is more compact (only one line) and less cluttered.
FWIW, I'm running a patched Okular with a different (hard coded) background colour since years, because basing the non-page background colour on the window background colour gives a very ugly result in my case (I don't think the code is to blame here, it's just impossible to find an algorithm which works for every possible colour). But I'm not alone, the following bugs have a total of 36 votes as of today:
Looking at other apps like Gwenview or Libreoffice, those often allow to change the non-page background colour, too.
As for the maintenance argument, I don't think it holds: This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
More information about the Okular-devel