Review Request 130057: Bug 288042 - Option to reset forms

[Gilbert Assaf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/
-----------------------------------------------------------

(Updated Sept. 23, 2017, 7:08 p.m.)


Review request for Okular.


Changes
-------

Form reset doesn't switch focus anymore if ListEdits are involved. And the option is only visible in edit mode.


Bugs: 288042
    http://bugs.kde.org/show_bug.cgi?id=288042


Repository: okular


Description
-------

Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks CheckBoxEdit and ListEdit form elements. 

I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state I should reset/clear them. Especially for ComboBox, I am not sure if clearing them could be harmful.


Diffs (updated)
-----

  part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
  ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
  ui/formwidgets.cpp a1215ce7d88b428dccdc5cac54ad6c934a81d494 
  ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
  ui/pageview.cpp 9766422b927d23330ce9fced5af8d406cee6ccd2 
  ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
  ui/pageviewutils.cpp a46384afb3f976842d6693b60fb01fd474481d0d 


Diff: https://git.reviewboard.kde.org/r/130057/diff/4/

Changes: https://git.reviewboard.kde.org/r/130057/diff/3-4/


Testing
-------


Thanks,

Gilbert Assaf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170923/b4cd3294/attachment.html>