[okular] [Bug 382139] Sidebar tab button text unreadable on hover and when current tab is not focused

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382139

Nate Graham <pointedstick at zoho.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/oku
                   |                            |lar/e80972e18909ed4f061323d
                   |                            |1e5c4d2c8883c4943
         Resolution|---                         |FIXED

--- Comment #4 from Nate Graham <pointedstick at zoho.com> ---
Git commit e80972e18909ed4f061323d1e5c4d2c8883c4943 by Nathaniel Graham.
Committed on 22/09/2017 at 15:38.
Pushed by ngraham into branch 'Applications/17.08'.

Fix sidebar labels being unreadable when selected or hovered over

Summary:

Previously these labels were white-on-light-blue with light themes; now they
use the correct theme color property, and become black appropriately.

Test Plan:
Tested on KDE Neon (dev unstable). Verified that with the default Breeze color
scheme, tab text is more readable when hovered over and then active but not in
focus. See before and after:

{F3909142}

{F3909143}

Also tested these changes with all standard color schemes as well as the Oxygen
theme to make sure that there were no visual regressions.

Reviewers: aacid, #okular, #kde_applications, broulik, sander, rkflx

Reviewed By: aacid, #okular, #kde_applications, rkflx

Subscribers: rkflx

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7793

M  +7    -2    ui/sidebar.cpp

https://commits.kde.org/okular/e80972e18909ed4f061323d1e5c4d2c8883c4943

-- 
You are receiving this mail because:
You are the assignee for the bug.