Review Request 129893: Implement continuous search

[Albert Astals Cid]

> On set. 17, 2017, 10:20 a.m., Elvis Angelaccio wrote:
> > Ping? Or should I re-upload the patch on phabricator for better visibility?
> 
> Albert Astals Cid wrote:
>     Code is still wrong, what more visibility do you want? If you're not going to allow for yes/no, why do you need a roundtrip to the ui to decide to continue the search?
> 
> Anthony Fieroni wrote:
>     You mean wrong in searching practically not finished?

in mean wrong in architectuaraly wrong, i explained this like three times already, why is there a roundtrip to the ui so that the ui tells the core to continue, why just doens't the core continue by itslef?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review103715
-----------------------------------------------------------


On ago. 30, 2017, 2:47 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129893/
> -----------------------------------------------------------
> 
> (Updated ago. 30, 2017, 2:47 p.m.)
> 
> 
> Review request for Okular, KDE Usability and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers.
> 
> 
> Diffs
> -----
> 
>   core/document.cpp b725ecfc7 
>   ui/searchlineedit.cpp 74e6ef60c 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/129893/diff/3/
> 
> 
> Testing
> -------
> 
> Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog.
> 
> 
> File Attachments
> ----------------
> 
> Before: dialog asks if the search should continue from the beginning.
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png
> After: always continue search from beginning, with a non-intrusive notification.
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170918/41cad44b/attachment.html>