D7848: added the "remove this bookmark" to bookmarks section

Albert Astals Cid noreply at phabricator.kde.org
Sat Sep 16 18:43:08 UTC 2017


aacid added inline comments.

INLINE COMMENTS

> part.cpp:2187
> +        QUrl bookmarkUrlWithNoHash = QUrl(bookmark.url().toString().split('#')[0]);
> +        m_document->bookmarkManager()->removeBookmark( bookmarkUrlWithNoHash, bookmark );
> +    }

Any reason you're not just calling

BookmarkManager::removeBookmark( const DocumentViewport &vp );

?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7848

To: lexdem, #okular
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170916/c46c7d4a/attachment.html>


More information about the Okular-devel mailing list