D7662: Draw a dark rectangle around highlighted search results

Oliver Sander noreply at phabricator.kde.org
Mon Sep 4 18:19:00 UTC 2017


sander added a comment.


  > This applies to all highlights, i.e. text selection too, are you sure we want that?
  
  Are you sure we don't have that anyway?  I get a darker-blue rectangle around text selections even without the patch.
  
  > There's something weird going on with the drawing, i can easily get a bad state, see http://i.imgur.com/wDAQlcP.png which is https://ev.kde.org/reports/2017-en.pdf having searched for "a b c d e f " on the thumbnail bar in any word mode after scrolling up/down a few times.
  
  I cannot reproduce this, but I have a vague idea of what could be the cause.  Does it go away if you surround the three new lines by
  
    painter.save();
    [patch]
    painter.restore();
  
  ?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7662

To: sander, #okular
Cc: aacid, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170904/60d78341/attachment.html>


More information about the Okular-devel mailing list