D8415: Soften correctness of image file open check

Nathaniel Graham noreply at phabricator.kde.org
Sun Oct 22 20:07:09 UTC 2017


ngraham added a comment.


  Thanks for the patch: The Summary needs some reformatting:
  
  - Add the special keyword "BUG 385384" on its own line
  - Remove the quote from the Bugzilla ticket; instead briefly explain the change in your own words
  - No need to explain the code change; it should be self-explanatory, or else have comments in the code itself
  
  Can/did you test this patch with other PNG files to make sure it didn't break for other files?
  
  Otherwise, this looks good to me.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171022/c6163ea3/attachment.html>


More information about the Okular-devel mailing list