D8378: Start the text generation request via a queued connection

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> generator.cpp:255
>              d->mTextPageReady = false;
> -            d->textPageGenerationThread()->startGeneration( request->page() );
> +            // Queue the text generation request so that pixmap generation gets a change to start before the text generation
> +            QMetaObject::invokeMethod(d->textPageGenerationThread(), "startGeneration", Qt::QueuedConnection, Q_ARG(Okular::Page *, request->page()));

s/change/chance/

> generator.cpp:256
> +            // Queue the text generation request so that pixmap generation gets a change to start before the text generation
> +            QMetaObject::invokeMethod(d->textPageGenerationThread(), "startGeneration", Qt::QueuedConnection, Q_ARG(Okular::Page *, request->page()));
>          }

normalize Q_ARG signature (`Okular::Page *` vs `Okular::Page*`)

REPOSITORY
  R223 Okular

BRANCH
  queueTextRequest

REVISION DETAIL
  https://phabricator.kde.org/D8378

To: aacid, #okular, mlaurent
Cc: dvratil, mlaurent, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171020/3e57db90/attachment.html>