D8642: Rework saving of annotations and form data

[Albert Astals Cid]

aacid marked an inline comment as done.
aacid added a comment.


  > - 27. It is still very confusing when using Save, because for the user Continue and Cancel are exactly the same. Can we special-case with a flag and hide the last sentence and the button here? As Save is the more common operation, this would streamline the user experience massively and reduce frustration. Most users won't read the text and assume Save > Continue //will// actually save the changes.
  
  Done, even though it adds some code "duplication" its easier to have it that way than to add lots of more if branches for smaller code duplication
  
  > - 28. There is an inconsistency for Close: If a document `canSwapBackingFile` (e.g. for PDF), Continue will keep the document open, but if it cannot (e.g. for epub), Continue losing changes will close the document. I think Discard in the previous dialog is enough to //actually// close, so for Save (the only case triggered by closing) the Continue [l.c.] buttons can be removed, really.
  
  So this actually got fixed by the above change too, given that now you don't have Continue anymore on Close+Save this can't happen anymore 😸

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8642

To: aacid, mlaurent, rkflx
Cc: mwolff, rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171115/63856419/attachment.html>