D8642: Rework saving of annotations and form data

Milian Wolff noreply at phabricator.kde.org
Wed Nov 15 10:22:20 UTC 2017


mwolff added inline comments.

INLINE COMMENTS

> aacid wrote in documenttest.cpp:112
> i don't understand why we would use  QEXECTED_FAIL here, yes the annotations have been migrated so we compare docdata migration to false, at most we could use a qverify since one could argue qcompare with bools is weird, but why qexpected_fail?

phabricator UI issue: the comment is for the line above, i.e. there are now no more annotations. Before, there was one, which is why I wonder

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8642

To: aacid, mlaurent, rkflx
Cc: mwolff, rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171115/c0eabc43/attachment.html>


More information about the Okular-devel mailing list