D8642: Rework saving of annotations and form data

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D8642#166482, @rkflx wrote:
  
  > > 2. Got several "Lost annotation on document save, something went wrong" on the console. However, to prevent data loss this should show a warning in the UI and allow aborting (just show the warning dialog from below and amend the list appropriately). I'll try to add steps to reproduce as soon as I can (might be an annotation created elsewhere, i.e. already present in the document and thus should not be lost indeed).
  >
  > Steps to reproduce:
  >
  > - Download and Open sample document <https://www.antennahouse.com/antenna1/wp-content/uploads/2015/07/axf-annotation-1.pdf>, add annotation, Save.
  > - Observe warning on console ("Lost annotation on document save, something went wrong").
  > - Review sidebar shows only multiple "Page 1" where before the annotations where listed correctly (they are still shown in the document, though).
  > - Manual Reload restores all old annotations as well as the newly added one, Review sidebar no longer broken.
  >
  >   Given no actual data was lost, I'd not consider this critical anymore. However, it is quite scary and should be fixed.
  >
  >   The same behaviour can be seen when Okular opens `autotests/data/file1.pdf` annotated on Android with "Adobe Acrobat" or "MuPDF".
  >
  >   ---
  >
  >   Edit: To clarify, I assume this is fixable in the backend, no UI warning necessary as originally proposed.
  
  
  Found the problem and fixed in the branch (still need to update the diff here)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8642

To: aacid, mlaurent
Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171113/331880d0/attachment.html>