D8642: Rework saving of annotations and form data

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D8642#166462, @rkflx wrote:
  
  > Most of my final checks passed, there is one more serious problem though:
  >
  > 23. Data loss on external change despite trying to save: Open, add annotation, change file externally, wait for warning, Save. Instead of overwriting, there is an error in the UI ("Could not open file:///…") and on the console ("The document hasn't been reloaded/swapped correctly"). After this, the file is corrupted but non-zero sized, i.e. Okular is not able to open it (MuPDF works, amazingly). Binary diff shows annot stream added at the end, perhaps some problem there? Note that Cancel and Save as with a different filename does work correctly. We do seem to have the data, but there is an issue saving to a file with the same name (not sure what this means in terms of file handles).
  
  
  I can't reproduce this, what do you mean by change file externally exactly? touch? edit it? remove it? copy something else over? ( i tried touch and my awesome pdf editing skills with vim)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8642

To: aacid, mlaurent
Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171113/d072a351/attachment.html>