D8704: Don't use exec() to open dialogs

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Okular.
Restricted Application added a project: Okular.

REVISION SUMMARY
  exec() is blocking and should not be used if possible.
  
  Currently it makes impossible to interact with a 2nd okular window
  if the first window has the Properties or Embedded Files dialog open.
  
  It also causes a double delete crash when closing okular via dbus
  while either of those dialogs is open.
  
  We can use open() instead which does not block the event loop and fixes
  both the problems.

TEST PLAN
  1. Open the Properties or Embedded Files dialog, then close okular via dbus.
  2. Open two okular windows, then open the Properties or Embedded Files dialog in one of them and try to use the other window.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8704

AFFECTED FILES
  part.cpp

To: elvisangelaccio, #okular
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171107/322a4120/attachment.html>