[okular] [Bug 386176] okular: CMake Error in generators/spectre/CMakeLists.txt

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=386176

Henrik Fehlauer <rkflx at lab12.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/oku
                   |                            |lar/f777e2a9241c4f384f60c46
                   |                            |7e226eee85fb5bc98
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from Henrik Fehlauer <rkflx at lab12.net> ---
Git commit f777e2a9241c4f384f60c467e226eee85fb5bc98 by Henrik Fehlauer.
Committed on 03/11/2017 at 23:25.
Pushed by rkflx into branch 'master'.

Fix CMake Error in generators/spectre/CMakeLists.txt

Summary:
When porting from `add_library` to `okular_add_generator`, 2f9246ae42ce
missed to remove `MODULE` for spectre, which is already implicitly added
as can be seen
[here](https://phabricator.kde.org/source/kcoreaddons/browse/master/KF5CoreAddonsMacros.cmake;83623a46c9862ee37535de93427dec0b0c55e24d$139).

This causes the upcoming CMake 3.10 to print the error `Cannot find
source file`, which can be fixed by removing the superfluous `MODULE`.

Test Plan:
No error shown anymore with CMake 3.10.0-rc4. Still works with CMake
3.5.1.

Reviewers: #okular, ngraham

Reviewed By: ngraham

Tags: #okular

Differential Revision: https://phabricator.kde.org/D8612

M  +1    -1    generators/spectre/CMakeLists.txt

https://commits.kde.org/okular/f777e2a9241c4f384f60c467e226eee85fb5bc98

-- 
You are receiving this mail because:
You are the assignee for the bug.