D8379: PDF: Support the new poppler renderToImage with update callback

Milian Wolff noreply at phabricator.kde.org
Thu Nov 2 12:09:05 UTC 2017


mwolff accepted this revision.
mwolff added a comment.


  lgtm from my side

INLINE COMMENTS

> generator_pdf.cpp:920
> +
> +    // Since the timer lives in a thread without even loop we need to stop it ourselves
> +    // when the remaining time has reached 0

typo: "without _an_ even_t_ loop"

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8379

To: aacid, #okular, mlaurent, mwolff
Cc: mwolff, rkflx, ngraham, michaelweghorn, mlaurent, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171102/facbe9fb/attachment.html>


More information about the Okular-devel mailing list