D8612: Fix CMake Error in generators/spectre/CMakeLists.txt

Henrik Fehlauer noreply at phabricator.kde.org
Thu Nov 2 00:10:00 UTC 2017


rkflx created this revision.
rkflx added a reviewer: Okular.
Restricted Application added a project: Okular.

REVISION SUMMARY
  When porting from `add_library` to `okular_add_generator`, https://phabricator.kde.org/R223:2f9246ae42ce6276002641ac02d9c6b880bcf7a3
  missed to remove `MODULE` for spectre, which is already implicitly added
  as can be seen here <https://phabricator.kde.org/source/kcoreaddons/browse/master/KF5CoreAddonsMacros.cmake;83623a46c9862ee37535de93427dec0b0c55e24d$139>.
  
  This causes the upcoming CMake 3.10 to print the error `Cannot find
  source file`, which can be fixed by removing the superfluous `MODULE`.
  
  BUG: 386176

TEST PLAN
  No error shown anymore with CMake 3.10.0-rc4. Still works with CMake
  3.5.1.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8612

AFFECTED FILES
  generators/spectre/CMakeLists.txt

To: rkflx, #okular
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171102/fd4ec626/attachment.html>


More information about the Okular-devel mailing list