Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

[Gilbert Assaf]

> On Mai 31, 2017, 11:06 vorm., Luigi Toscano wrote:
> > Please check https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages for next reviews (in this case, BUG: and REVIEW: keyword were missing).
> > 
> > (also, this could have gone to the Applications/17.04 branch instead - Albert?)

sorry I saw this message to late. I was assuming just using rbt patch would be enough. I will definitly do this next time!


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130106/#review103255
-----------------------------------------------------------


On Mai 31, 2017, 11:03 vorm., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130106/
> -----------------------------------------------------------
> 
> (Updated Mai 31, 2017, 11:03 vorm.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 262265
>     http://bugs.kde.org/show_bug.cgi?id=262265
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular sends a 'qFatal()', if no encoding could be guessed. This will also create a core dump crashing Okular and all open document in this instance.
> 
> 
> Diffs
> -----
> 
>   generators/chm/lib/libchmfileimpl.cpp 3ae4e98ddf8876a996a34ab710ffa0ab71f52cde 
> 
> Diff: https://git.reviewboard.kde.org/r/130106/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170531/bc07a60f/attachment.html>