Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

Gilbert Assaf gassaf at gmx.de
Wed May 31 11:03:09 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130106/
-----------------------------------------------------------

(Updated Mai 31, 2017, 11:03 vorm.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Bugs: 262265
    http://bugs.kde.org/show_bug.cgi?id=262265


Repository: okular


Description
-------

Okular sends a 'qFatal()', if no encoding could be guessed. This will also create a core dump crashing Okular and all open document in this instance.


Diffs
-----

  generators/chm/lib/libchmfileimpl.cpp 3ae4e98ddf8876a996a34ab710ffa0ab71f52cde 

Diff: https://git.reviewboard.kde.org/r/130106/diff/


Testing
-------


Thanks,

Gilbert Assaf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170531/1d5b6927/attachment.html>


More information about the Okular-devel mailing list