Review Request 130113: kio_msits emits mimetype again

Albert Astals Cid aacid at kde.org
Wed May 31 10:49:46 UTC 2017



> On mai. 31, 2017, 10:48 a.m., Gilbert Assaf wrote:
> > Ship It!

Why are you giving shipit to yourself?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130113/#review103253
-----------------------------------------------------------


On mai. 3, 2017, 1:40 p.m., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130113/
> -----------------------------------------------------------
> 
> (Updated mai. 3, 2017, 1:40 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> kio_msits emitting mimetype function ported to QT5. A kio slave should always emit the mimetype (see kio slave api doc).
> 
> 
> Diffs
> -----
> 
>   generators/chm/kio-msits/msits.cpp 0a53e0c9d78373155cd0a0efb7fa667e62fb7e32 
> 
> Diff: https://git.reviewboard.kde.org/r/130113/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170531/2733d2cc/attachment.html>


More information about the Okular-devel mailing list