Review Request 130131: Initialize cursor in PageView scrollbars with ArrowCursor (fixes bug 334798)

[Oliver Sander]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130131/#review103221
-----------------------------------------------------------



I tested it, and it appears to work.

- Oliver Sander


On May 15, 2017, 8:30 p.m., Tobias Deiminger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130131/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 8:30 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 334798
>     http://bugs.kde.org/show_bug.cgi?id=334798
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> QT Docs [say](http://doc.qt.io/qt-5/qwidget.html#cursor-prop): "If no cursor has been set, or after a call to unsetCursor(), the parent's cursor is used."
> For us this means, as long as PageView child scrollbars are not initialized, their cursor will be whatever the PageView cursor is. I think it's reasonable to let the scrollbar cursors always be an arrow, unconditionally.
> 
> Furthermore, would you expect the cursor in selection mode to change from cross back to arrow if it resides in the "empty grey space" in between the page and the scrollbar? At the moment the patch doesn't change that behaviour, cursor will stay a cross there.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 28cf77df9d92b92a33f427217a1438bc452c0eb0 
> 
> Diff: https://git.reviewboard.kde.org/r/130131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Deiminger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170517/f36a1cef/attachment.html>