Review Request 130057: Bug 288042 - Option to reset forms
Gilbert Assaf
gassaf at gmx.de
Wed Mar 29 09:25:26 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/
-----------------------------------------------------------
Review request for Okular.
Bugs: 288042
http://bugs.kde.org/show_bug.cgi?id=288042
Repository: okular
Description
-------
Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks CheckBoxEdit and ListEdit form elements.
I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state I should reset/clear them. Especially for ComboBox, I am not sure if clearing them could be harmful.
Diffs
-----
part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074
ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c
ui/formwidgets.cpp 6ab49b0ed9fa3ba71486cf45e89e46c7b0f61d3f
ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65
ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191
ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80
ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c
Diff: https://git.reviewboard.kde.org/r/130057/diff/
Testing
-------
Thanks,
Gilbert Assaf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170329/be303056/attachment.html>
More information about the Okular-devel
mailing list