Review Request 130012: Change pages in presentation mode by swiping on touch screen - Alternative implementation

Oliver Sander oliver.sander at tu-dresden.de
Sun Mar 19 23:35:26 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130012/
-----------------------------------------------------------

(Updated March 20, 2017, 2:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 618072f8a2ea77ba7ad1241abac088487dee04b3 by Albert Astals Cid on behalf of Oliver Sander to branch master.


Repository: okular


Description
-------

This is an alternative implementation of https://git.reviewboard.kde.org/r/125847/ . Unlike that, this new implementation does not disable synthesizing of mouse events from touch events.  As a consequence, you can still draw on the touch screen with your finger.  However, when swiping to change the page in drawing mode, more often than not the first finger on the screen will leave a mark.


Diffs
-----

  ui/presentationwidget.h 28630e67 
  ui/presentationwidget.cpp 526c235e 

Diff: https://git.reviewboard.kde.org/r/130012/diff/


Testing
-------


Thanks,

Oliver Sander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170319/2530da1a/attachment-0001.html>


More information about the Okular-devel mailing list