Review Request 126378: remove kactivities on windows

Patrick Spendrin ps_ml at gmx.de
Sat Mar 18 00:58:47 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126378/
-----------------------------------------------------------

(Updated March 17, 2017, 5:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdewin and Okular.


Changes
-------

Submitted with commit 3859fba07d67db264974b16838f76d2e5f20eb57 by Albert Vaca on behalf of Oliver Sander to branch master.


Repository: okular


Description
-------

KActivities is not used on Windows, so a hard dependency on it
only brings unneeded code.
This patch removes it completely under Windows.


Diffs
-----

  CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
  shell/CMakeLists.txt 7a6af745464fe7bb1d6702cc02787e7e6d4c101e 
  shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 

Diff: https://git.reviewboard.kde.org/r/126378/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170318/bae777a8/attachment.html>


More information about the Okular-devel mailing list