Review Request 124276: Separated bookmarks.xml so that every document have its own bookmarks file

[Nikola Nikolic]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124276/
-----------------------------------------------------------

(Updated March 11, 2017, 5:57 p.m.)


Status
------

This change has been discarded.


Review request for Okular and Albert Astals Cid.


Bugs: 342258
    http://bugs.kde.org/show_bug.cgi?id=342258


Repository: okular


Description
-------

Instead of single bookmarks.xml, there is now bookmarks folder with separated bookmarks for each document and
_bookmarkedFiles.xml that contain information ( folder tags ) about bookmarked documents.
I have also changed BookmarkList class, so that only top level items ( folder titles from _bookmarkedFiles.xml ) are
loaded at begining. Subitems are loaded when needed ( bookmarks searched, tree expanded ).

This makes Okular load faster ( bug 342258 ), but also gives us opportunity to save bookmarks and annotations in the
same folder where document is, addressing problems described in bug 176743 and bug 267350.

There is some change in bookmark metadata that occur during conversion from old bookmarks system to new, example:

before conversion:

<bookmark href="file:///home/nikola/neki_fajl.txt#0;C2:0.499253:0.636771:1">
 <title>prvi bookmark</title>
 <info>
  <metadata owner="http://freedesktop.org">
   <bookmark:icon name="text-plain"/>
  </metadata>
 </info>
</bookmark>

after conversion:

<bookmark href="file:///home/nikola/neki_fajl.txt#0;C2:0.499253:0.636771:1">
 <title>prvi bookmark</title>
 <info>
  <metadata owner="http://freedesktop.org">
   <n1:icon name="text-plain" xmlns:n1="http://www.freedesktop.org/standards/desktop-bookmarks"/>
  </metadata>
 </info>
</bookmark>

I don't know what causes this change, but it seems that Okular doesn't use this info at all.


Diffs
-----

  core/bookmarkmanager.h e24efc6 
  core/bookmarkmanager.cpp 22951b2 
  core/document.cpp 9d12488 
  ui/bookmarklist.h 03acd43 
  ui/bookmarklist.cpp 1db03df 

Diff: https://git.reviewboard.kde.org/r/124276/diff/


Testing
-------

Everything seems to work, except communication between two Okular processes.

If I open multiple windows in single Okular process, and change bookmarks from one window signal is sent to all
windows from that process. If I have have two different Okular process, and change bookmarks from one window 
signal is not sent to window in second process. I don't know how to fix this.


Thanks,

Nikola Nikolic

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170311/d5f9fe4e/attachment-0001.html>