Review Request 126809: Allow to rotate the page view using two-finger pinches on a touchscreen

Albert Astals Cid aacid at kde.org
Sat Mar 11 17:34:31 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126809/#review102797
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On Oct. 16, 2016, 9:39 a.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126809/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2016, 9:39 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> With this patch you can rotate pages by touching your touchscreen with two fingers and then rotating the fingers.  No fancy animation is implemented; all this patch does is call slotRotate[Counter]Clockwise when
> the corresponding Qt gesture is triggered.
> 
> Sorry for again posting patches against the 'frameworks' branch.  This patch is trivial to backport to the master branch, and as far as I understand Qt, it should work there just the same.  Only it doesn't -- no gesture events are ever received.  Feel free to ignore this patch until 'frameworks' has been merged into the master branch.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 339ba69 
> 
> Diff: https://git.reviewboard.kde.org/r/126809/diff/
> 
> 
> Testing
> -------
> 
> Works on my ThinkPad Yoga 12 with today's Debian testing.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170311/af6b1815/attachment.html>


More information about the Okular-devel mailing list