Review Request 129284: Don't jump up 1/2 page on file reload if scrolled to page (with left-right cursor)
Albert Astals Cid
aacid at kde.org
Sat Mar 11 17:15:42 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129284/#review102795
-----------------------------------------------------------
What do you mean with "if scrolled to page (with left-right cursor)"?
Maybe you can add an autotest for this?
- Albert Astals Cid
On Oct. 30, 2016, 2:28 p.m., Miklós Máté wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129284/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2016, 2:28 p.m.)
>
>
> Review request for Okular.
>
>
> Repository: okular
>
>
> Description
> -------
>
> This fixes the problem for now, but the whole load/relayout/scroll logic cries for a refactoring. For example, upon loading a file the viewport is set 4 times, and if the viewport was "104" initially, it becomes "104;C2:0.49933:0.499527:1" in the end.
>
>
> Diffs
> -----
>
> ui/pageview.cpp bb540cb
>
> Diff: https://git.reviewboard.kde.org/r/129284/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Miklós Máté
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170311/3b50fbaa/attachment-0001.html>
More information about the Okular-devel
mailing list