Review Request 130187: CHMGenerator code modernization

[Albert Astals Cid]

> On July 24, 2017, 11:08 a.m., Albert Astals Cid wrote:
> > i'd be happier if we don't touch the code in lib/ and kio-msits since it's "copied" from kchmviewer.
> > 
> > At some point it would make sense if someone has time to go and see how much kchmviewer code has changed and if it makes sense updating our "copy".
> > 
> > What do you think?
> 
> Gilbert Assaf wrote:
>     Sounds reasonable. I will look into this.
> 
> Gilbert Assaf wrote:
>     kchmviewer did a rewrite of those classes a few years ago. I suggest we use their current version and integrate them in okular. Although we might need a rewrite of our generator_chm class.

Seems like a good idea, again if you have the time :)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130187/#review103466
-----------------------------------------------------------


On July 20, 2017, 2:40 p.m., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130187/
> -----------------------------------------------------------
> 
> (Updated July 20, 2017, 2:40 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> - Removes lib/lchmurlhandler.cpp (contains no code)
> - Use keyword override
> - Usage of proper Include Guards
> - Fixes order of includes
> - Introduces usage of nullptr
> - Introduces usage of auto
> - Removes usage of QString:null
> 
> 
> Diffs
> -----
> 
>   generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
>   generators/chm/autotests/chmgeneratortest.cpp 6b0b8efc7e9395d137f2cd36876e8197accbfc16 
>   generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
>   generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
>   generators/chm/kio-msits/msits.cpp 50bac0c100b9dd816d55a817c021ff083e3d5202 
>   generators/chm/lib/lchmurlhandler.h 35133c41d764de551a350a240d8ee43d07f84716 
>   generators/chm/lib/lchmurlhandler.cpp 9d98d87e147539ef30817b3c66a040aa750575ad 
>   generators/chm/lib/libchmfileimpl.h f8d7cc11269a2688fd8b58a30d718ff911b051b3 
>   generators/chm/lib/libchmfileimpl.cpp d10602028e958e7feded362b2ab58e32ca1d1ff0 
>   generators/chm/lib/libchmtextencoding.cpp 0ed3f0710360c7bab113a35c7896e6bbd6664d20 
>   generators/chm/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
>   generators/chm/lib/libchmtocimage.cpp 2952e8604d8c01360eace2826bbf5dc428155ff1 
> 
> Diff: https://git.reviewboard.kde.org/r/130187/diff/
> 
> 
> Testing
> -------
> 
> With clang4.0 
> some work was done with clang-tidy: https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170731/5678efc6/attachment-0001.html>