Review Request 130176: Get paper format names from Qt

[Oliver Sander]

> On July 11, 2017, 11:04 p.m., Albert Astals Cid wrote:
> > -2
> > 
> > the qt name returns a translated string and i doubt that's what lpr wants

Oh, indeed, I missed that.  To be honest, the lpr documentation is pretty vague about what lpr wants here, but let's just leave things as they are then.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130176/#review103428
-----------------------------------------------------------


On July 10, 2017, 8:13 p.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130176/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 8:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The method FilePrinter::mediaPageSize contains a long hard-coded list of names of the different paper format names (like 'A4', 'Letter', etc.).  This patch removes the list and gets the names from Qt instead.
> 
> Actually, this may change three obscure format names, but it really smells like they were wrong to begin with.  Look for the lines marked  
> 
>     // Correct translation?
>     
> in the old code.
> 
> 
> Diffs
> -----
> 
>   core/fileprinter.cpp a8b584937 
> 
> Diff: https://git.reviewboard.kde.org/r/130176/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170712/f2ef8690/attachment.html>