Review Request 130176: Get paper format names from Qt

Oliver Sander oliver.sander at tu-dresden.de
Mon Jul 10 20:13:43 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130176/
-----------------------------------------------------------

Review request for Okular.


Repository: okular


Description
-------

The method FilePrinter::mediaPageSize contains a long hard-coded list of names of the different paper format names (like 'A4', 'Letter', etc.).  This patch removes the list and gets the names from Qt instead.

Actually, this may change three obscure format names, but it really smells like they were wrong to begin with.  Look for the lines marked  

    // Correct translation?
    
in the old code.


Diffs
-----

  core/fileprinter.cpp a8b584937 

Diff: https://git.reviewboard.kde.org/r/130176/diff/


Testing
-------


Thanks,

Oliver Sander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170710/e8553d2a/attachment.html>


More information about the Okular-devel mailing list