Review Request 130057: Bug 288042 - Option to reset forms

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/#review103403
-----------------------------------------------------------



How does this play with undo/redo?

I haven't tried but i think this would feel weird (please try):

* Open a file with two fields
* Go to field 1 and write "hola"
* Go to field 2 and write "adios"
* Go to field 1 and delete everything
* Now press "Clear forms"
* Now press "undo", what happens? if my guess is right, field 1 will go to "hola" and field 2 will stay empty, which is exactly the opposite of what you had when pressing "Clear forms"


part.rc (line 2)
<https://git.reviewboard.kde.org/r/130057/#comment68820>

    You need to increase the verison if you add new stuff.


- Albert Astals Cid


On mar. 30, 2017, 7 p.m., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130057/
> -----------------------------------------------------------
> 
> (Updated mar. 30, 2017, 7 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 288042
>     http://bugs.kde.org/show_bug.cgi?id=288042
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks CheckBoxEdit and ListEdit form elements. 
> 
> I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state I should reset/clear them. Especially for ComboBox, I am not sure if clearing them could be harmful.
> 
> 
> Diffs
> -----
> 
>   part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
>   ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
>   ui/formwidgets.cpp 6ab49b0ed9fa3ba71486cf45e89e46c7b0f61d3f 
>   ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
>   ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 
>   ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
>   ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c 
> 
> Diff: https://git.reviewboard.kde.org/r/130057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170702/569440db/attachment.html>