Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review102232
-----------------------------------------------------------



This regresses in this file

http://www.postgresql.org/files/documentation/pdf/8.4/postgresql-8.4-A4.pdf

Open that file with this patch, search for " in ", i.e "in" with a space before and after

An occurrence will be found on page 2 "appear in all"

Now press "Next"

It will find an occurrence where In is at the beginning of a new line. I don't think that's the expected behaviour (and doesn't happen without your patch)

- Albert Astals Cid


On Jan. 21, 2017, 9:52 p.m., Marduk Bolanos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2017, 9:52 p.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -----
> 
>   okular/autotests/searchtest.cpp 1a41930 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> -------
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170123/07cb0404/attachment.html>