Review Request 129785: Stop debug spam in release builds

[Albert Astals Cid]

> On Jan. 7, 2017, 1:24 p.m., Luigi Toscano wrote:
> > Does it mean that you can't override the setting using kdebugsettings? If it's the case, it's probably a no-go.
> 
> Miklós Máté wrote:
>     Oh, sorry I didn't realize how important this is:
>     "/usr/local/lib/x86_64-linux-gnu/plugins/okular/generators/okularGenerator_poppler.so"
>     org.kde.okular.core: Output DPI: QSizeF(94.1467, 94.0741)
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 1
>     org.kde.okular.core: sending request observer=0x56187c9b8210 853x1205 at 0 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 853x1205 at 1
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 1
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 0 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 0
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 1
>     org.kde.okular.core: requestDone with generator not in READY state.
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 1 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 0
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 1
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 2
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 3
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 4
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 5
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 0 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 1 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 2 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 3 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 4 async == true isTile == false
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 5 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 2
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 2 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 3
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 3 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 4
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 4 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 5
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 5 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 6
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 6 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 7
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 7 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 6
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 6 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 8
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 8 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 7
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 7 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 8
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 8 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 9
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 9 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 9
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 9 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 10
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 10 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 10
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 10 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9b8210 833x1177 at 11
>     org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177 at 11 async == true isTile == false
>     org.kde.okular.core: request observer=0x56187c9a19e0 108x153 at 11
>     org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153 at 11 async == true isTile == false
>     org.kde.okular.core: About to save document info to "/home/miki/.local/share/okular/docdata/269712.flowratios.pdf.xml"
>     No frame loaded
>     No frame loaded
>     No frame loaded
>     
>     (BTW I couldn't track down where the last three lines are printed on exit)
>     
>     The kdebugdialog5 settings have no effect on these printouts (I disabled everything for okular, and checked "Disable all debug output" to be sure), probably because they are qDebug and not kDebug. I have two questions about this tool:
>     - How did you find it? It doesn't have a menu entry.
>     - Is there a difference between kdebugdialog and kdebugdialog5?
> 
> Miklós Máté wrote:
>     One more thing: the debug spam from Okular is nothing compared to the Help Center.

Why are you using kdebugdialog5 when Luigi said kdebugsettings ?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129785/#review101848
-----------------------------------------------------------


On Jan. 7, 2017, 12:51 p.m., Miklós Máté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129785/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 12:51 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular core prints lots of debug messages, stop that in release builds.
> 
> 
> Diffs
> -----
> 
>   OkularConfigureChecks.cmake 70fe8768 
>   ui/formwidgets.cpp 7e68b5c7 
> 
> Diff: https://git.reviewboard.kde.org/r/129785/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170111/d9a438be/attachment-0001.html>