Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

> On Jan. 8, 2017, 1:27 a.m., Albert Astals Cid wrote:
> > please explain me why "a\n" and "a " should return true but "aa\n" and "aa " should return false?

I understand that you are worried about this being a general string-comparison function, but AFAIK with the current search algorithm the case you are considering will not occur. If I missed your point, please explain in more detail.


- Marduk


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101856
-----------------------------------------------------------


On Jan. 5, 2017, 10:20 a.m., Marduk Bolanos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 10:20 a.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -----
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> -------
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170108/d5719eca/attachment-0001.html>