Review Request 129773: Escape closes fullscreen

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129773/#review101802
-----------------------------------------------------------



I honestly don't think this is a good idea, all the KDE apps that have full screen go into it with Ctrl+Shift+F and out of it by the same, adding Esc just adds inconsistency to it.

- Albert Astals Cid


On Jan. 4, 2017, 4:35 p.m., Hartmut Brüning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129773/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 4:35 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366276
>     http://bugs.kde.org/show_bug.cgi?id=366276
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I introduced a m_exitFullScreenAction that listens on escape key. It is active in full screen mode only. I tested that escape key in menu or dialogs are not affected by this change.
> 
> 
> Diffs
> -----
> 
>   shell/shell.h d015b3fc 
>   shell/shell.cpp 448b9ff7 
> 
> Diff: https://git.reviewboard.kde.org/r/129773/diff/
> 
> 
> Testing
> -------
> 
> yes:
> 
> press escape in normal mode
>     -> nothing happens -> ok
> clicked into menu, press escape
>     -> menu closes -> ok
> opened configure menu, press escape
>     -> configure menu closes -> ok
> opened file dialog, press escape
>     -> file dialog closes -> ok
> switched to fullscreen, press escape
>     -> fullscreen closes -> ok
> switched to fullscreen, right click, close fullscreen
>     -> fullscreen closes -> ok
> switched to fullscreen, right click, press escape, press escape
>     -> context menu opens, closes and fullscreen closes -> ok
> press Ctrl+Shift+F, press Ctrl+Shift+F -> fullscreen opens and closes
>     -> ok
> press Ctrl+Shift+F, press escape -> fullscreen opens and closes
>     -> ok
> switch to fullscreen, terminate okular, start reokular, press escape
>     -> okular starts in fullscreen and closes fullscreen -> ok
> 
> 
> Thanks,
> 
> Hartmut Brüning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170104/76a37036/attachment.html>