refactoring in pageview class

[Albert Astals Cid]

El dimarts, 14 de febrer de 2017, a les 10:26:35 CET, Jonathan Schultz va 
escriure:
> Hear hear!
> 
> PageView really is a a mess, I presume because it has been repeatedly
> added to as okular has grown from kpdf and never been subject to a
> proper clean-up. Notably (and in addition to the
> PageView/PageViewPrivate confusion you mention), it has massively long
> functions (eg mouseReleaseEvent has over 700 lines), overly complex and
> sometimes redundant internal data structures, and its logic is quite
> opaque. Not surprisingly, there are inconsistencies and bugs in the UI -
> here are a couple I have raised to little or no feedback:
> 
> https://bugs.kde.org/show_bug.cgi?id=363776
> https://bugs.kde.org/show_bug.cgi?id=361538
> https://git.reviewboard.kde.org/r/127496/
> 
> My personal interest stems from having forked okular for my own project
> (https://github.com/jschultz/okular-tagging), for which I am extending
> the UI. Given the apparent lack of enthusiasm for small but helpful
> changes (such as your patch to use escape to leave full-screen mode,
> like just about every full-screen application in the world!) 

First two apps i tried to go out of fullscreen with Esc:
 * kate
 * firefox
Neither go out of fullscreen with Esc.

Best Regards,
  Albert