Review Request 129893: Implement continuous search

Elvis Angelaccio elvis.angelaccio at kde.org
Thu Feb 9 22:08:10 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
-----------------------------------------------------------

(Updated Feb. 9, 2017, 10:08 p.m.)


Review request for Okular, KDE Usability and Albert Astals Cid.


Repository: okular


Description
-------

Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers.


Diffs
-----

  core/document.h 1fd86262 
  core/document.cpp 41b9ddfe 
  ui/searchlineedit.cpp baac8be0 

Diff: https://git.reviewboard.kde.org/r/129893/diff/


Testing (updated)
-------

Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170209/08f37c54/attachment.html>


More information about the Okular-devel mailing list