Review Request 129893: Implement continuous search
Albert Astals Cid
aacid at kde.org
Thu Feb 2 23:38:40 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102350
-----------------------------------------------------------
i'm not sure i agree with this change, but this doesn't seem the proper way to do it, if we're going to continue searching anyways, don't send a Okular::Document::EndOfDocumentReached, just continue searching.
- Albert Astals Cid
On feb. 1, 2017, 11:20 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129893/
> -----------------------------------------------------------
>
> (Updated feb. 1, 2017, 11:20 p.m.)
>
>
> Review request for Okular and Albert Astals Cid.
>
>
> Repository: okular
>
>
> Description
> -------
>
> Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers.
>
>
> Diffs
> -----
>
> core/document.h 1fd86262
> core/document.cpp 41b9ddfe
> ui/searchlineedit.cpp baac8be0
>
> Diff: https://git.reviewboard.kde.org/r/129893/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170202/bde9ddcf/attachment.html>
More information about the Okular-devel
mailing list