Review Request 129909: Fix reading comicbooks in zip format
Eugene Shalygin
eugene.shalygin at gmail.com
Wed Feb 1 12:56:57 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129909/
-----------------------------------------------------------
(Updated Лют. 1, 2017, 1:56 після полудня)
Review request for Okular and Albert Astals Cid.
Changes
-------
file opening was under Q_ASSERT
Repository: okular
Description
-------
Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` is not seekable and because of that `QImageLoader` can't detect image format. Proposed solution: if that device is not seekable or `QIODevice::size()` returns 0, copy its content into a temporary file and load image from it.
Diffs (updated)
-----
generators/comicbook/document.cpp 34c4cb5a
Diff: https://git.reviewboard.kde.org/r/129909/diff/
Testing
-------
Well, it loads .cbr files now :)
Thanks,
Eugene Shalygin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170201/b4e63b14/attachment.html>
More information about the Okular-devel
mailing list