D9328: Add support for cancellable image rendering and text extraction

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D9328#179878, @michaelweghorn wrote:
  
  > I tested this a bit and find it really nice that rendering of the actual page (rather than the thumbnail) usually starts at once when re-rendering is needed (e.g. when zoom level is changed).
  >  Also, closing Okular now works fast, even if rendering is still in progress. (The shell prompt is shown almost immediately after closing Okular when it was started from the command line.)
  >
  > While the above is true most of the time, it happens from time to time that rendering does not start at once.
  >  I can reproduce this e.g. the following way:
  >
  > - open a file that takes long to render
  > - zoom "one step" in and out every few seconds (using the mouse wheel)
  >
  >   While re-rendering is triggered most of the times at once, the page sometimes remains "blank" for more than 30 seconds. In those cases where the page is "blank", it also takes long for the Okular process to finish when closing the program at that point in time.
  >
  >   I (temporarily) uploaded a screencast here: https://ombx.io/4SDa42mm
  
  
  That seems like a bug, it shouldn't do that, i'll try to reproduce here.
  
  > Another thing I realized is that re-rendering is now triggered every time the zoom level is changed.
  >  Without this change, rendering the page is sometimes just continued at the place where it was before changing the zoom level (which results in the final page appearing earlier when no re-rendering is needed).
  
  Yes and no, what happened before is that after the first rendering finished a second one would start with the correct quality for the current zoom, but since the first one was probably "good enough" you got a scaled version while the second one was rendering, which sometimes it may be good, some other times it may be ultra pixelated, now we just cancel the first one and start the second one right away, so the time to "best/correct rendering" is shorter but the time to "something renderer" is a bit larger. I do think that this approach is better.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9328

To: aacid
Cc: michaelweghorn, ngraham, #okular, gassaf, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20171215/1cd32374/attachment.html>