Review Request 130235: Allow to select Splash or Arthur render backends

[Oliver Sander]

> On Aug. 24, 2017, 8:45 p.m., Albert Astals Cid wrote:
> > Arthur is useless, I don't see why we should we expose a much worse experience to the user.
> 
> Oliver Sander wrote:
>     For developing/debugging.  Remember that I claimed that Arthur can in principle help with some of Okular's printing problems.
>     
>     
>     Arthur really is useless at this point, but it is not hopeless: lot's of improvements can actually be done with very limited time and skills. Exposing it in Okular (with a suitable warning) may get a bit more developer interest.
> 
> Albert Astals Cid wrote:
>     For developing/debugging i'd say go for an #ifdef.

Certainly not.  I want to be able to switch between the different renderers in a running program, to be able to conveniently compare the output.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130235/#review103649
-----------------------------------------------------------


On Aug. 24, 2017, 8:37 p.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130235/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 8:37 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This patch adds a new configuration option to the pdf backend options: the user can select between the poppler Splash or Arthur backends.  Of course Splash is the default, but it's nice to have the choice -- I use it to debug Arthur.
> 
> I need some help, though (still Qt newbie).  With the current patch, backend changes do not go into effect until the document is reloaded. How do I make it go into effect when 'Ok' is clicked?  I suppose there's some signal that gets emitted, but what's its name?
> 
> Also, It'd be good to add a 'here be dragons' tooltip to the Arthur choice.  Is that possible?
> 
> 
> Diffs
> -----
> 
>   generators/poppler/conf/pdfsettings.kcfg 65ea82d8d 
>   generators/poppler/conf/pdfsettingswidget.ui 488ad3099 
>   generators/poppler/generator_pdf.cpp 2a73ca205 
> 
> Diff: https://git.reviewboard.kde.org/r/130235/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170830/99aa0424/attachment.html>