D7595: Skip reload when another reload is already in progress

Henrik Fehlauer noreply at phabricator.kde.org
Wed Aug 30 06:26:28 UTC 2017


rkflx added a comment.


  I guess someone else should judge which is easier to read considering the full picture (I got confused by your `areWeReloading` naming, actually). I admit someone not familiar with `std::mutex` semantics would need to read the comment, but understanding a custom RAII wrapper is even harder.
  
  Could you suggest another reviewer?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7595

To: rkflx, #okular
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170830/4a58b35c/attachment.html>


More information about the Okular-devel mailing list