Review Request 129893: Implement continuous search

[Albert Astals Cid]

> On feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way to do it, if we're going to continue searching anyways, don't send a Okular::Document::EndOfDocumentReached, just continue searching.
> 
> Elvis Angelaccio wrote:
>     Should we ask input from the usability team maybe? I find the messagebox annoying because it usually gets in the way. If I trigger Next it's because I have not yet found what I was looking for, so I *always* click the Continue button in the messagebox.
> 
> Albert Astals Cid wrote:
>     You're reading a 20 page document, you've already read up to page 10, and then you decide to search for "very important thing", why would you want to wrap if you've already read the first 10 pages?
>     
>     Anyhow sure try to get someone from usability, but comparing okular to kate is an apples to pineapples comparison imnsho.
> 
> Elvis Angelaccio wrote:
>     Consider this use case: I open a pdf because I need to search something in there. Not the first time I open this pdf, so it gets open somewhere after the beginning of the document. Which means there is a good chance that I reach the end of the document without finding what I was looking for. That's why I think the "continue from beginning?" dialog can be annoying.
> 
> Elvis Angelaccio wrote:
>     @Albert: I tried to rework this patch to work without `EndOfDocumentReached`, but I can't figure it out. It seems to me that we cannot get rid of it (otherwise I don't know how to notify that we reached the first or last page).

Why not? Just do it where EndOfDocumentReached is emitted?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102350
-----------------------------------------------------------


On mar. 11, 2017, 5:41 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129893/
> -----------------------------------------------------------
> 
> (Updated mar. 11, 2017, 5:41 p.m.)
> 
> 
> Review request for Okular, KDE Usability and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers.
> 
> 
> Diffs
> -----
> 
>   core/document.h 1fd86262 
>   core/document.cpp 41b9ddfe 
>   ui/searchlineedit.cpp baac8be0 
> 
> Diff: https://git.reviewboard.kde.org/r/129893/diff/
> 
> 
> Testing
> -------
> 
> Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog.
> 
> 
> File Attachments
> ----------------
> 
> Before: dialog asks if the search should continue from the beginning.
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png
> After: always continue search from beginning, with a non-intrusive notification.
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170829/53f526f6/attachment-0001.html>