Review Request 130235: Allow to select Splash or Arthur render backends
Oliver Sander
oliver.sander at tu-dresden.de
Thu Aug 24 20:37:25 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130235/
-----------------------------------------------------------
Review request for Okular.
Repository: okular
Description
-------
This patch adds a new configuration option to the pdf backend options: the user can select between the poppler Splash or Arthur backends. Of course Splash is the default, but it's nice to have the choice -- I use it to debug Arthur.
I need some help, though (still Qt newbie). With the current patch, backend changes do not go into effect until the document is reloaded. How do I make it go into effect when 'Ok' is clicked? I suppose there's some signal that gets emitted, but what's its name?
Also, It'd be good to add a 'here be dragons' tooltip to the Arthur choice. Is that possible?
Diffs
-----
generators/poppler/conf/pdfsettings.kcfg 65ea82d8d
generators/poppler/conf/pdfsettingswidget.ui 488ad3099
generators/poppler/generator_pdf.cpp 2a73ca205
Diff: https://git.reviewboard.kde.org/r/130235/diff/
Testing
-------
Thanks,
Oliver Sander
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170824/a2420037/attachment.html>
More information about the Okular-devel
mailing list