D7382: add markdown support

Albert Astals Cid noreply at phabricator.kde.org
Tue Aug 22 21:14:41 UTC 2017


aacid added a comment.


  It doesn't build on Ubuntu 17.04
  
    /home/kdeunstable/okular/generators/markdown/converter.cpp: In member function ‘virtual QTextDocument* Markdown::Converter::convert(const QString&)’:
    /home/kdeunstable/okular/generators/markdown/converter.cpp:46:40: error: ‘MKD_FENCEDCODE’ was not declared in this scope
       if ( !mkd_compile( markdownHandle, MKD_FENCEDCODE | MKD_GITHUBTAGS | MKD_AUTOLINK ) ) {
                                          ^~~~~~~~~~~~~~
    /home/kdeunstable/okular/generators/markdown/converter.cpp:46:57: error: ‘MKD_GITHUBTAGS’ was not declared in this scope
       if ( !mkd_compile( markdownHandle, MKD_FENCEDCODE | MKD_GITHUBTAGS | MKD_AUTOLINK ) ) {
  
  Uses discount 2.1.8-2

INLINE COMMENTS

> converter.cpp:57
> +    mTextDocument = new QTextDocument;
> +    mTextDocument->setPageSize( QSizeF( 980, 1307 ) );
> +    mTextDocument->setHtml( html );

980x1307 is an interesting size, any specific reaosn you choose that one?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7382

To: progwolff, #okular
Cc: michaelweghorn, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170822/356529e1/attachment.html>


More information about the Okular-devel mailing list