Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

[Gilbert Assaf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130078/
-----------------------------------------------------------

(Updated April 26, 2017, 1:40 nachm.)


Review request for Okular.


Changes
-------

I added an unit test, I figured this might be helpful for reviewing this patch.


Bugs: 236688
    http://bugs.kde.org/show_bug.cgi?id=236688


Repository: okular


Description
-------

All pages in a CHM File are now ordered accordingly to TOC Data. If a page is not in TOC, it will be added at the end.


Diffs (updated)
-----

  generators/chm/CMakeLists.txt 22015955dba2519d485f22951e320694ebe82a7f 
  generators/chm/autotests/chmgeneratortest.cpp PRE-CREATION 
  generators/chm/autotests/data/test.chm PRE-CREATION 
  generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 

Diff: https://git.reviewboard.kde.org/r/130078/diff/


Testing
-------

I created a small example chm file to test this. I can provide the file, if someone would like to have it.


Thanks,

Gilbert Assaf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170426/e5e6befa/attachment.html>