Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

[Oliver Sander]

> On Sept. 4, 2016, 3:38 p.m., Anthony Fieroni wrote:
> > ui/pageview.cpp, line 1504
> > <https://git.reviewboard.kde.org/r/128821/diff/2/?file=475954#file475954line1504>
> >
> >     Martin wants early return for code clarification
> >     if (!pinch) {
> >         return false;
> >     }

I don't think he does, after all.  See his comment starting with 'Fair enough' above.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review98878
-----------------------------------------------------------


On Sept. 4, 2016, 7:48 p.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2016, 7:48 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366781
>     http://bugs.kde.org/show_bug.cgi?id=366781
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The attached patch implements document zoom controlled by a two-finger pinch gesture on a touch screen.
> 
> The actual zooming was done by copy'n'paste, I don't understand the full details of how zooming works in okular, yet.  So a bit of review would be appreciated.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.h 01c39bf 
>   ui/pageview.cpp cd53407 
> 
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
> 
> 
> Testing
> -------
> 
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160904/de08e0e2/attachment.html>